[GR-43971] Support native-image environment variable capturing in bundles. #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
paw/GR-43971
branch
2 times, most recently
from
44db22a
to
88952c6
Compare
13 tasks
github-actions bot
pushed a commit
to Mic92/nixpkgs
that referenced
this pull request
Dec 17, 2023
…of CC wrapper Instead of using a hacky CC wrapper to re-inject the environment variables needed to build, we set the NATIVE_IMAGE_DEPRECATED_BUILDER_SANITATION=true that is in 21.0.0 release changelog: https://github.com/oracle/graal/blob/489611a304ec808cdcb1e07e9a9799e6240fd2e1/substratevm/CHANGELOG.md?plain=1#L48 This is deprecated behavior for now, and will be removed in future, but this will allow us more time until we figure a proper solution. See: - oracle/graal#7502 - oracle/graal#7981 - oracle/graal#6095
hamburger1984
pushed a commit
to hamburger1984/nixpkgs
that referenced
this pull request
Dec 18, 2023
…of CC wrapper Instead of using a hacky CC wrapper to re-inject the environment variables needed to build, we set the NATIVE_IMAGE_DEPRECATED_BUILDER_SANITATION=true that is in 21.0.0 release changelog: https://github.com/oracle/graal/blob/489611a304ec808cdcb1e07e9a9799e6240fd2e1/substratevm/CHANGELOG.md?plain=1#L48 This is deprecated behavior for now, and will be removed in future, but this will allow us more time until we figure a proper solution. See: - oracle/graal#7502 - oracle/graal#7981 - oracle/graal#6095
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
-E<env-var-key>[=<env-var-value>]andPreviously almost all environment variables were simply forwarded to the builder. With this PR we changed the behavior to only have a minimum set of environment variables passed through to the builder. If an image build requires additional access to environment variables during image build-time, the new option
has to be used.
To temporarily revert back to the old behaviour, env setting
NATIVE_IMAGE_DEPRECATED_BUILDER_SANITATION=truecan be used. The old behavior might get removed in a future release.💡 If you experience image build errors after this PR and using
NATIVE_IMAGE_DEPRECATED_BUILDER_SANITATION=truemake the errors go away you determined that your image build depends on custom environment variables. Please identify those env-vars and add them to your image build options (with-E).